Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init path in infra messenger #1942

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Init path in infra messenger #1942

merged 1 commit into from
Oct 8, 2018

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Oct 8, 2018 •
edited by kormat
Loading

Initialize path

This change is Reviewable

@oncilla oncilla requested a review from scrye October 8, 2018 13:37
scrye
scrye approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

kormat
kormat approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 399c8c1 into scionproto:master Oct 8, 2018
@oncilla oncilla deleted the go-pr-fix branch October 8, 2018 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kormat kormat kormat approved these changes

@scrye scrye scrye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oncilla @scrye @kormat